CUDA: add DGX Spark network expert/tensor parallelism - #754
Open
shankinson wants to merge 1 commit into
Open
Conversation
shankinson
force-pushed
the
agent/cuda-network-ep-tp
branch
from
August 9, 2026 04:00
dba112c to
d6e64ad
Compare
shankinson
marked this pull request as ready for review
August 9, 2026 04:07
|
I have 2x DGX Sparks I would love to get ds4 running on. I can test if it would help. |
Author
The changes should work with that setup. I've got 4 DGX sparks connected via a 200gbps switch and it worked in both 2 node and 4 node trials. Let me know if you run into any issues with it. |
Add guarded two- and four-rank NCCL execution for supported DeepSeek Flash and GLM 5.2 layouts, including model-aware expert and dense decode sharding. Wire mirrored sessions through the CLI, benchmark, server, agent, eval, and official continuation scorer, with protocol/kernel tests and release documentation.
shankinson
force-pushed
the
agent/cuda-network-ep-tp
branch
from
August 12, 2026 18:11
d6e64ad to
e3cd1c9
Compare
|
What speed can DSv4 Flash achieve on 2x DGX? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ds4,ds4-bench,ds4-server,ds4-agent,ds4-eval, and the official-continuation scorer.Related upstream issues
ds4-server(and also wires the agent, eval, benchmark, and scorer frontends).--ssd-streamingprefill failure remains outside this PR.Supported paths and safety
--transport autoornccl) with rank worlds of 2 or 4.DS4_CUDA_TP_FAST_ALIGNED_EXPERTS=1remains an explicit DeepSeek throughput opt-in because its aligned representation changes rounding; it is not the default parity path.Validation completed
192.168.2.30through.33; reviewed sources are byte-identical across ranks.93/93 backend-adjusted checks passed on macOS.
ds4_test --serverpasses.a49de64c...b07fea0).ds4-server: real/v1/chat/completionsrequest completed; graceful shutdown stopped all ranks with status 0.ds4-agent: the non-interactive prompt returned exactlyOK; all ranks exited cleanly.ds4-eval: one 64-token GPQA case completed and all ranks exited cleanly (the quantized model selected C for a fixture whose answer is B, so the quality harness itself returned 1).avg_nll=0.403166544, 61/100 greedy first-token matches); the matched single-Spark reference measuredavg_nll=0.406647149.avg_nll=0.468965305, 83/100 greedy first-token matches,avg_lcp=6.850, and 99.768% API top-logprob mapping coverage. All workers exited with status 0.ds4,ds4-server,ds4-bench,ds4-eval, andds4-agent.make testpassed againstDeepSeek-V4-Flash-0731-IQ2XXS-w2Q2K-AProjQ8-SExpQ8-OutQ8-ds4.gguf; Metal mapped 82,697.67 MiB and passed the 30,474-token long-context, tool-call, official logprob, local-golden, kernel, and tensor-equivalence checks.make test-metal-session-batchpassed with 2 sessions, 6 decode steps, an 8-token mixed suffix, and exact logits.The network control protocol is intended for trusted cluster networks and is not authenticated or release-stable yet; every rank should run the same commit and model bytes.